[PATCH 1/2] Add a help button to every Anaconda screen
vpodzime at redhat.com
Mon Sep 1 13:39:54 UTC 2014
> > >
> > > screenshots_directory = "/tmp/anaconda-screenshots"
> > > @@ -536,6 +542,7 @@ class GraphicalUserInterface(UserInterface):
> > >
> > > # Use connect_after so classes can add actions before we change
> > > screens
> > > obj.window.connect_after("continue-clicked",
> > > self._on_continue_clicked)
> > > + obj.window.connect_after("help-button-clicked",
> > > self._on_help_clicked, obj)
> > > obj.window.connect_after("quit-clicked", self._on_quit_clicked)
> > >
> > I'm not sure whether any of these should really be connect_after...the comment
> > does not really help me much.
> Well, I'm just expecting the signal handlers already present know what
> they are doing. Any GTK guru willing to comment if _after is actually
> needed ?
The docs say "The handler will be called after the default handler of
the signal." So I guess we want to keep the default handler running (if
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches