[master/f21] Wait until all spokes are setup before updating continue button

Vratislav Podzimek vpodzime at redhat.com
Thu Oct 30 09:25:18 UTC 2014


On Wed, 2014-10-29 at 15:59 -0700, Brian C. Lane wrote:
> There's no need to call this inside the hub's spoke loop, wait until the
> end. This shaves about 6 seconds off the delay between the welcome
> screen and the status hub in my tests.
> ---
>  pyanaconda/ui/gui/hubs/__init__.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/hubs/__init__.py b/pyanaconda/ui/gui/hubs/__init__.py
> index 523580e..98b5e3f 100644
> --- a/pyanaconda/ui/gui/hubs/__init__.py
> +++ b/pyanaconda/ui/gui/hubs/__init__.py
> @@ -154,7 +154,7 @@ class Hub(GUIObject, common.Hub):
>  
>                  # Set some default values on the associated selector that
>                  # affect its display on the hub.
> -                self._updateCompleteness(spoke)
> +                self._updateCompleteness(spoke, update_continue=False)
>                  spoke.selector.connect("button-press-event", self._on_spoke_clicked, spoke)
>                  spoke.selector.connect("key-release-event", self._on_spoke_clicked, spoke)
>  
> @@ -194,6 +194,7 @@ class Hub(GUIObject, common.Hub):
>          spokeArea.add(viewport)
>  
>          setViewportBackground(viewport)
> +        self._updateContinue()
>  
>      def _updateCompleteness(self, spoke, update_continue=True):
>          spoke.selector.set_sensitive(spoke.sensitive and spoke.ready)
Nice, ACK.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list