[PATCH] Handle the case of rpmostreepayload + GRUB2
Brian C. Lane
bcl at redhat.com
Thu Oct 16 22:03:48 UTC 2014
On Thu, Oct 16, 2014 at 10:17:12AM -0400, Colin Walters wrote:
> + boot_extlinux = boot + '/extlinux'
> + if os.path.isdir(boot_extlinux):
> + boot_syslinux = boot + '/syslinux'
> + boot_loader = boot + '/loader'
> + assert os.path.isdir(boot_loader)
Why the assert? If that fails it's going to blow up the installation
with a traceback. It would be better to handle the error in some clean
way.
> + # And if we're using GRUB2, move its config file, also with a
> + # compatibility symlink.
> + boot_grub2 = boot + '/grub2'
> + if os.path.isdir(boot_grub2):
> + boot_loader = boot + '/loader'
> + assert os.path.isdir(boot_loader)
Same here.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
More information about the anaconda-patches
mailing list