[PATCH 1/2] Remove the code that reads /tmp/vncshell.pid.

Vratislav Podzimek vpodzime at redhat.com
Wed Oct 15 08:28:07 UTC 2014


On Tue, 2014-10-14 at 17:15 -0400, David Shea wrote:
> The code that writes it was removed in 2006.
> ---
>  pyanaconda/exception.py | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/pyanaconda/exception.py b/pyanaconda/exception.py
> index b60ac0f..6a9b9cd 100644
> --- a/pyanaconda/exception.py
> +++ b/pyanaconda/exception.py
> @@ -28,7 +28,6 @@ from pyanaconda import iutil, kickstart
>  import sys
>  import os
>  import shutil
> -import signal
>  import time
>  import re
>  import errno
> @@ -188,14 +187,6 @@ class AnacondaExceptionHandler(ExceptionHandler):
>                  and self._intf_tty_num != 1:
>              iutil.vtActivate(1)
>  
> -        pidfl = "/tmp/vncshell.pid"
> -        if os.path.exists(pidfl) and os.path.isfile(pidfl):
> -            pf = open(pidfl, "r")
> -            for pid in pf.readlines():
> -                if not int(pid) == os.getpid():
> -                    os.kill(int(pid), signal.SIGKILL)
> -            pf.close()
> -
>          os.open("/dev/console", os.O_RDWR)   # reclaim stdin
>          os.dup2(0, 1)                        # reclaim stdout
>          os.dup2(0, 2)                        # reclaim stderr
These both look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list