[master/f21] Fix # handling in SimpleConfigFile (#1045687)

Vratislav Podzimek vpodzime at redhat.com
Tue Oct 14 11:26:36 UTC 2014


On Mon, 2014-10-13 at 14:16 -0700, Brian C. Lane wrote:
> It was treating anything after a # as a comment, even if it appeared
> inside a quoted string. This fixes it to find the last # outside a
> (optional) quoted string and adds several tests.
> 
> This also adds back the non-IfcfgFile tests for SimpleConfigFile from
> old_tests
> ---
>  pyanaconda/simpleconfig.py                  |  30 ++++++-
>  tests/pyanaconda_tests/simpleconfig_test.py | 128 ++++++++++++++++++++++++++++
>  2 files changed, 154 insertions(+), 4 deletions(-)
>  create mode 100644 tests/pyanaconda_tests/simpleconfig_test.py
Nice, looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list