[PATCH better version] Initialize the GUI lock in a way that doesn't break the API

David Shea dshea at redhat.com
Fri Oct 10 20:29:25 UTC 2014


On 10/10/2014 12:50 PM, David Shea wrote:
> +        if not gui_lock:
> +            gui_lock = threading.Lock()
> +        self._gui_lock = gui_lock
> +

It just occurred to me that this part is kind of silly, too. Instead of 
creating a new Lock here, I think I'll change this to just keep the None 
coming in as the default and change this part

> +        if not self._gui_lock.acquire(False):

to if self._gui_lock and not self._gui_lock.acquire(False)


More information about the anaconda-patches mailing list