[master] Skip running efibootmgr for noefi mode (#1047904)

Vratislav Podzimek vpodzime at redhat.com
Thu Oct 9 06:13:33 UTC 2014


On Wed, 2014-10-08 at 17:12 -0700, Brian C. Lane wrote:
> noefi on the cmdline tells the kernel not to make runtime EFI calls so
> Anaconda should skip trying to run efibootmgr.
> 
> Note that noefi does NOT mean do a BIOS install. To do that the system
> needs to be booted in CSM mode.
> ---
>  pyanaconda/bootloader.py | 4 ++++
>  pyanaconda/flags.py      | 3 ++-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index 1bc10c9..3178027 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -1670,6 +1670,10 @@ class EFIGRUB(GRUB2):
>              log.info("Skipping efibootmgr for image/directory install.")
>              return ""
>  
> +        if "noefi" in flags.cmdline:
> +            log.info("Skipping efibootmgr for noefi")
> +            return ""
> +
>          if kwargs.pop("capture", False):
>              exec_func = iutil.execWithCapture
>          else:
> diff --git a/pyanaconda/flags.py b/pyanaconda/flags.py
> index 5403f75..5636b44 100644
> --- a/pyanaconda/flags.py
> +++ b/pyanaconda/flags.py
> @@ -69,6 +69,7 @@ class Flags(object):
>          # ksprompt is whether or not to prompt for missing ksdata
>          self.ksprompt = True
>          self.rescue_mode = False
> +        self.noefi = False
>          # parse the boot commandline
>          self.cmdline = BootArgs()
>          # Lock it down: no more creating new flags!
> @@ -78,7 +79,7 @@ class Flags(object):
>  
>      def read_cmdline(self):
>          for f in ("selinux", "debug", "leavebootorder", "testing", "extlinux",
> -                  "gpt", "dnf"):
> +                  "gpt", "dnf", "noefi"):
>              self.set_cmdline_bool(f)
>  
>          if not selinux.is_selinux_enabled():
ACK.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list