[blivet:master 00/10] Consistency in RAID level related checks (v2)

mulhern amulhern at redhat.com
Tue Oct 7 13:42:25 UTC 2014


Everything is the same bar recommended changes except for
* Adjust detection of exception raised (the regular expressions were too broad)
* The final five patches, which refactor testing infrastructure for devices
and add some new tests to test setting dataLevel and metadataLevel in BTRFS.

Note: I'ld rather keep the RaidDevice class separate for now. 
It's a lightweight class with no state of its own or constructor. If we
want to make it extend ContainerDevice at a later time, we can.

mulhern (10):
  Do not set parents attribute if parents param is bad.
  Add new RaidDevice class for handling RAID aspects of devices.
  Use new RaidDevice class in appropriate Device subclasses.
  Update test setup so that it obeys RAID level requirements.
  Adjust detection of exceptions raised.
  Move getting the attribute into the check methods.
  Refactor setup of _state_functions into __init__() methods
  Add isleaf and direct to _state_functions
  Add dataLevel and metaDataLevel attributes for testing.
  Add a few test for setting dataLevel and metaDataLevel in BTRFS

 blivet/devices/btrfs.py     |  67 +++---
 blivet/devices/device.py    |   6 +-
 blivet/devices/md.py        |  45 ++--
 blivet/devices/raid.py      | 106 +++++++++
 tests/devicefactory_test.py |   8 +-
 tests/devices_test.py       | 518 ++++++++++++++++++++++++++++----------------
 6 files changed, 493 insertions(+), 257 deletions(-)
 create mode 100644 blivet/devices/raid.py

-- 
1.9.3



More information about the anaconda-patches mailing list