[PATCH 1/2] Fall back to parted to detect dasd disklabels.

Samantha N. Bueno sbueno+anaconda at redhat.com
Thu Oct 2 19:53:11 UTC 2014


On Thu, Oct 02, 2014 at 02:25:06PM -0500, David Lehman wrote:
> blkid does not know how to detect dasd disklabels, so we cannot rely on
> the information provided by udev in this case.

As I've already tested this numerous times with success, ack.

The other one looks ok to me as well, but someone else might want to
take a look at it.
 
> Resolves: rhbz#1144410
> ---
>  blivet/devicetree.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/blivet/devicetree.py b/blivet/devicetree.py
> index 3b59171..6afc356 100644
> --- a/blivet/devicetree.py
> +++ b/blivet/devicetree.py
> @@ -1228,7 +1228,9 @@ class DeviceTree(object):
>          disklabel_type = udev.device_get_disklabel_type(info)
>          log_method_call(self, device=device.name, label_type=disklabel_type)
>          # if there is no disklabel on the device
> -        if disklabel_type is None:
> +        # blkid doesn't understand dasd disklabels, so bypass for dasd
> +        if disklabel_type is None and not \
> +           (device.isDisk and udev.device_is_dasd(info)):
>              log.debug("device %s does not contain a disklabel", device.name)
>              return
>  
> -- 
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list