[PATCH 1/3] Remove redundant _set_container_members method.

David Lehman dlehman at redhat.com
Thu Oct 2 19:46:54 UTC 2014


The member set is always updated as part of the child factory's
configure method, so this method never changes anything.
---
 blivet/devicefactory.py | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py
index fbc2231..41bafe8 100644
--- a/blivet/devicefactory.py
+++ b/blivet/devicefactory.py
@@ -500,7 +500,6 @@ class DeviceFactory(object):
         if getattr(self.container, "exists", False):
             return
 
-        self._set_container_members()
         self._set_container_raid_level()
 
         # check that the container is still large enough to contain whatever
@@ -509,21 +508,6 @@ class DeviceFactory(object):
             # only do this check if we're not doing post-removal cleanup
             self._check_container_size()
 
-    def _set_container_members(self):
-        if not self.child_factory:
-            return
-
-        members = self.child_factory.devices
-        log.debug("new member set: %s", [d.name for d in members])
-        log.debug("old member set: %s", [d.name for d in self.container.parents])
-        for member in self.container.parents[:]:
-            if member not in members:
-                self.container.parents.remove(member)
-
-        for member in members:
-            if member not in self.container.parents:
-                self.container.parents.append(member)
-
     def _set_container_raid_level(self):
         pass
 
-- 
1.9.3



More information about the anaconda-patches mailing list