[blivet:master 0/5] size.py related patches (v3)
Vratislav Podzimek
vpodzime at redhat.com
Thu Oct 2 13:46:41 UTC 2014
On Thu, 2014-10-02 at 08:26 -0400, mulhern wrote:
> First three patches are unchanged from (v2).
>
> Next patch now allows type of min_value to include Decimal as well as int, long,
> since I realized that it would be legitimate to specify that 0.75 GiB was how
> you wanted to see that value and it does't change the code at all. Simplified
> description of min_value as I realized that its specification was simpler
> than I had previously thought.
>
> Last patch is new.
>
> mulhern (5):
> Use UPPER_CASE for constants
> Use named constants for binary and decimal factors.
> Factor out commonalities in xlated_*_prefix() methods.
> Rewrite of Size.humanReadable() method
> Change default min_value from 10 to 1 in humanReadable()
>
> blivet/size.py | 195 ++++++++++++++++++++++++++++-------------------------
> tests/size_test.py | 80 +++++++++++++++++++---
> 2 files changed, 176 insertions(+), 99 deletions(-)
ACK.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list