[blivet:master 1/3] Rewrite of Size.humanReadable() method

Anne Mulhern amulhern at redhat.com
Wed Oct 1 12:09:58 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Wednesday, October 1, 2014 5:32:32 AM
> Subject: Re: [blivet:master 1/3] Rewrite of Size.humanReadable() method
> 
> On Tue, 2014-09-30 at 08:27 -0400, mulhern wrote:

<-- SNIP -->

> >  
> > +# Empty prefix works both for decimal and binary
> > +_emptyPrefix = _Prefix(1, "".decode("utf-8"), "".decode("utf-8"))
> Any reason for not using u"" here instead of calling decode() on an
> old/byte string?
> 
> Otherwise this looks good to me.
> 

None at all. Fixed.

> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

- mulhern


More information about the anaconda-patches mailing list