[f21-branch][PATCH] clean up stage1 volume check, check format as well as mountpoint

Adam Williamson awilliam at redhat.com
Sat Nov 29 00:49:33 UTC 2014


On Fri, 2014-11-28 at 13:51 -0800, Adam Williamson wrote:
> This is a follow-on from e2d10a04. To reduce the change from
> the previous behaviour and minimize the chance of any strange
> corner-case breakage, this sorts the disk list, rather than
> filtering it.
> 
> It also now checks the format_type constraint as well as the
> mountpoint constraint. There are platforms (PPC) which use a
> volume as the stage1 target, but don't require it to be mounted;
> this handles those as well as platforms which require the target
> volume to be mounted to a specific location.

After a mere six hours or so of watching a veeeeery sloooooow qemu ppc64
install grind away, I can say this looks like it works for the PPC64
case (as a test of the 'stage1 is a partition with no mountpoint' path):
I successfully did a custom part install placing the prepboot partition
on /dev/sdb without specifying a boot disk, as expected anaconda
picked /dev/sdb as the 'boot disk' and there were no errors. Bootloader
installation succeeded and the installed system boots from sdb. I also
checked that without my change, this case behaves just like the UEFI
case initially identified.

I'll probably run a couple of kickstart tests, but I think this is
pretty sane and safe now.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net



More information about the anaconda-patches mailing list