[blivet:master 00/11] A bunch of small changes and a new set of tests

mulhern amulhern at redhat.com
Tue Nov 25 23:22:36 UTC 2014


I'ld like to add these tests to repo now, so that I have some regressions
I can use to check my ongoing development in separate branch.
The rest of the changes are things that allow a quick fix. The basic
idea is that if they are fixed, the tests won't have to be written to
accomodate these little bugs, and that will make things simpler later.

Most are pretty obvious, but

* Check resizable...
* Change "Aggregate..."
* Set NTFS._formattable...,
* Add another check...

were judgement calls and probably need a closer look.

Set NTFS._formattable... is significant, because if _formattable is false
it is not possible to create an NTFS filesystem.

The simple tests have a bunch of FIXME's and CHECKME's in them.
FIXME's are things I'm pretty confident are wrong, but that are kind of
hard to fix. CHECKME's are things I'm not super sure about, but that
look dubious.

mulhern (11):
  Make default exists value a boolean in DeviceFormat.__init__.
  Check resizable when assigning a new target size.
  Simplify _getSize() and currentSize().
  Split informaton from infofs program for size on whitespace.
  Change "Aggregate block size:" to "Physical block size:" for JFS.
  Make an early exit if self._existingSizeFields is []
  Simplify FS.free().
  Set NTFS._formattable to True.
  Add another check for resizable in FS.doResize()
  Get rid of long() related code.
  Add a bunch of simple tests for filesystem formats.

 blivet/formats/__init__.py      |   2 +-
 blivet/formats/fs.py            |  46 +++---
 tests/formats_test/fs_test.py   | 105 +++++++++++++
 tests/formats_test/fstesting.py | 334 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 462 insertions(+), 25 deletions(-)
 create mode 100755 tests/formats_test/fs_test.py
 create mode 100644 tests/formats_test/fstesting.py

-- 
1.9.3



More information about the anaconda-patches mailing list