[PATCH] datetime_spoke: Fix warnings about removing nonexistent source

Colin Walters walters at verbum.org
Tue Nov 25 20:34:13 UTC 2014


On Tue, Nov 25, 2014, at 02:29 PM, Vratislav Podzimek wrote:
> On Tue, 2014-11-25 at 08:46 -0500, Colin Walters wrote:
> > First, we missed setting the variable to None in one place for the
> > update source.
> > 
> > Second, when the "start updating" source returns False, we need to set
> > the corresponding variable to None as well in the source itself to
> > preserve the invariant that the ID is non-None if and only if the
> > source is outstanding.
> > ---
> >  pyanaconda/ui/gui/spokes/datetime_spoke.py | 3 +++
> >  1 file changed, 3 insertions(+)
> Looks good to me. Thanks.

I don't have commit access, can someone take care of pushing this?


More information about the anaconda-patches mailing list