[blivet:master 0/2] Add a new pylint checker (v3)

mulhern amulhern at redhat.com
Mon Nov 24 19:53:41 UTC 2014


The changes from v1 are:
* Fixed a bug in the checker where it would give false positive in case
where there is an overridden value that is not a literal. There were no
instances where this was occurring in the code, so it was not an obvious
problem.
* Commented the checker analysis more heavily to document its restrictions.
* Added an additional checker in the same vein that detects a tiny subset of
pointless function overrides.
* Removed the (1) pointless function override that the new checker found
(in second patch).

The only change from (v2) is that it is a lot tidied up and some
uniformities taken care of. An identical set of statements is removed in 
patch (2).

mulhern (2):
  Add a simple pylint checker for pointless overrides.
  Remove pointless overrides.

 blivet/formats/biosboot.py         |   1 -
 blivet/formats/disklabel.py        |   1 -
 blivet/formats/dmraid.py           |   3 -
 blivet/formats/fs.py               |  10 --
 blivet/formats/luks.py             |   1 -
 blivet/formats/multipath.py        |   3 -
 blivet/formats/prepboot.py         |   1 -
 tests/formats_test/init_test.py    |   3 -
 tests/pylint/pointless-override.py | 252 +++++++++++++++++++++++++++++++++++++
 tests/pylint/pylint-one.sh         |   2 +-
 10 files changed, 253 insertions(+), 24 deletions(-)
 create mode 100644 tests/pylint/pointless-override.py

-- 
1.9.3



More information about the anaconda-patches mailing list