[blivet:master 0/2] Add a new pylint checker
Vratislav Podzimek
vpodzime at redhat.com
Thu Nov 20 07:03:20 UTC 2014
On Wed, 2014-11-19 at 11:36 -0500, mulhern wrote:
> And then use it.
>
> This change should have the result that every assignment to a class
> attribute in a class is required because it overrides the assignment
> in the parent class with a different value.
>
> mulhern (2):
> Add a simple pylint checker for pointless class attribute overrides.
> Remove pointless class attribute overrides.
>
> blivet/formats/biosboot.py | 1 -
> blivet/formats/disklabel.py | 1 -
> blivet/formats/dmraid.py | 3 -
> blivet/formats/fs.py | 10 ----
> blivet/formats/luks.py | 1 -
> blivet/formats/multipath.py | 3 -
> blivet/formats/prepboot.py | 1 -
> tests/pylint/pointless-override.py | 120 +++++++++++++++++++++++++++++++++++++
> tests/pylint/pylint-one.sh | 2 +-
> 9 files changed, 121 insertions(+), 21 deletions(-)
> create mode 100644 tests/pylint/pointless-override.py
These both look good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list