[blivet:master 0/2] A couple of small pylint inspired patches.

Vratislav Podzimek vpodzime at redhat.com
Wed Nov 19 07:22:30 UTC 2014


On Tue, 2014-11-18 at 18:09 -0500, mulhern wrote:
> The first was inspired by a class of pylint errors, the C (Convention) ones
> that are disabled in our tests. I happened to run pylint-gui for fun and this
> one popped out at me by pure luck.
> 
> However, if the C error were undisabled there would be about 
> 3000 new errors, mostly quite pointless, about too-long-lines and missing-
> docstrings.
> 
> The one that made me notice bug in patch (1) was the superfluous-parens
> error. There are 55 other instances of just this, but they all appear benign.
> Fixing them wouldn't be hard, but it would be a busy commit with no real
> useful affect.
> 
> So I'm leaving the C errors disabled.
A good strategy, I'd say. :) Other than on suggestion these both look
good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list