[PATCH] Related bug can have different fixed-in and state

Vratislav Podzimek vpodzime at redhat.com
Tue Nov 18 09:11:41 UTC 2014


On Fri, 2014-11-14 at 07:26 -0800, Brian C. Lane wrote:
> If a related bug is the same as the bug listed in the summary it
> overrides the need for a matching fixed-in or state. eg. a fix to a
> patch previously pushed that is already ON_QA or has an older fixed-in
> version.
> 
> If the bug in the summary is different from the related bug that implies
> Resolved and it must have correct state, fixed-in and acks.
> ---
>  scripts/makebumpver | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/makebumpver b/scripts/makebumpver
> index 941b509..fa2df04 100755
> --- a/scripts/makebumpver
> +++ b/scripts/makebumpver
> @@ -356,8 +356,12 @@ class MakeBumpVer:
>                              not self._isRHELBugAcked(ckbug, commit, summary)):
>                              bad = True
>                          elif valid and action == 'Related':
> +                            # A related bug needs to have acks, and if it is the same as the summary
> +                            # It overrides the summary having different fixed-in or state
>                              if self._isRHELBugAcked(ckbug, commit, summary):
>                                  print "*** Bug %s Related commit %s is allowed\n" % (bug, commit)
> +                                if ckbug == summary_bug:
> +                                    bad = False
>                              else:
>                                  bad = True
ACK and it already proved itself working on the rhel7-branch as I see.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list