[blivet:master 2/2] Get rid of FS._getRandomUUID() method.

David Lehman dlehman at redhat.com
Wed Nov 12 20:19:20 UTC 2014


On 11/12/2014 06:52 AM, mulhern wrote:
> The method was introduced in anaconda commit
> bd1123738d8a6ea671f472c663ed8e1c882f93a7 in 2011 Jan, but was not used in
> that commit and hasn't beeen used since.

I believe it was used in the old livecd backend to replace the UUID of 
the rootfs after doing a block-level copy onto the target device.

These both look okay to me.

David

>
> If we really needed a random uuid method it should go in utils, but we do
> not.
>
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>   blivet/formats/fs.py | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
> index 2199381..4de70c8 100644
> --- a/blivet/formats/fs.py
> +++ b/blivet/formats/fs.py
> @@ -681,10 +681,6 @@ class FS(DeviceFormat):
>
>           self.notifyKernel()
>
> -    def _getRandomUUID(self):
> -        uuid = util.capture_output(["uuidgen"]).strip()
> -        return uuid
> -
>       @property
>       def needsFSCheck(self):
>           return False
>



More information about the anaconda-patches mailing list