[blivet][master] prop up unit tests

Anne Mulhern amulhern at redhat.com
Tue Nov 11 23:04:21 UTC 2014





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, November 11, 2014 4:32:47 PM
> Subject: [blivet][master] prop up unit tests
> 
> Patch 1 is needed for ImageBackedTestCase to work since something
> reliably prevents kpartx from removing dm partition device nodes
> when we remove the partitions using pyparted. For whatever reason,
> we can remove them using dmsetup.
> 
> Patches 2 and 3 fix parted.Partition lookup for partitions on DiskFile
> disks.
> 
> "Temporarily disable..." is just a hack so we can start running tests
> without a proper solution to whatever the underlying problem is with
> mdadm_test.
> 
> David Lehman (6):
>   Fix test that guards forcible removal of dm partition nodes.
>   devicePathToName should default to returning a basename.
>   Pass a path (not a name) to devicePathToName.
>   The minimum size for a btrfs member device has increased to 16 MiB.
>   Temporarily disable a test that isn't working.
>   Don't run selinux context tests when selinux is disabled.
> 
>  blivet/devices/lib.py                | 5 +++++
>  blivet/devices/partition.py          | 6 ++++--
>  tests/devicelibs_test/btrfs_test.py  | 2 +-
>  tests/devicelibs_test/mdraid_test.py | 1 +
>  tests/formats_test/selinux_test.py   | 1 +
>  5 files changed, 12 insertions(+), 3 deletions(-)
> 
> --
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Can you also add that patch you had which saves and restores all those values
in StorageTestCase.setUp() and teardown() to this patch set?

- mulhern


More information about the anaconda-patches mailing list