[blivet:master 2/4] Update minSize method headers.

David Lehman dlehman at redhat.com
Tue Nov 4 17:49:43 UTC 2014


On 11/04/2014 10:46 AM, mulhern wrote:
> minSize values are no longer in megabytes and a value of Size(0) is
> ambiguous.
>
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>   blivet/formats/__init__.py | 9 ++++++++-
>   blivet/formats/fs.py       | 2 --
>   2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/blivet/formats/__init__.py b/blivet/formats/__init__.py
> index 4867f9c..0891dc5 100644
> --- a/blivet/formats/__init__.py
> +++ b/blivet/formats/__init__.py
> @@ -484,7 +484,14 @@ class DeviceFormat(ObjectID):
>
>       @property
>       def minSize(self):
> -        """ Minimum size for this format type. """
> +        """ Minimum size for this format type.
> +
> +            :rtype: :class:`~.size.Size`
> +
> +            Note that a value of Size(0) can mean either that the
> +            minimum size is unknown, or that the minimum size is
> +            actually Size(0).
> +        """

I don't think anything actually has a minimum size of 0 bytes. That 
would indicate it being actually gone, no?

David

>           return self._minSize
>
>       @property
> diff --git a/blivet/formats/fs.py b/blivet/formats/fs.py
> index 3205a57..3f824fa 100644
> --- a/blivet/formats/fs.py
> +++ b/blivet/formats/fs.py
> @@ -1379,7 +1379,6 @@ class NTFS(FS):
>
>       @property
>       def minSize(self):
> -        """ The minimum filesystem size. """
>           return self._minInstanceSize
>
>       @property
> @@ -1585,7 +1584,6 @@ class TmpFS(NoDevFS):
>
>       @property
>       def minSize(self):
> -        """ The minimum filesystem size in megabytes. """
>           return self._minInstanceSize
>
>       @property
>



More information about the anaconda-patches mailing list