[PATCH] When locating the EFI bootDevice, ensure that it has a mountpoint (#1145812)

Anne Mulhern amulhern at redhat.com
Mon Nov 3 21:05:47 UTC 2014





----- Original Message -----
> From: "Brian C. Lane" <bcl at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Friday, October 31, 2014 8:53:18 PM
> Subject: Re: [PATCH] When locating the EFI bootDevice, ensure that it has a	mountpoint (#1145812)
> 
> On Fri, Oct 31, 2014 at 07:00:58PM -0400, mulhern wrote:
> > Resolves: rhbz#1145812
> > 
> > The EFI boot device is not considered valid unless it has a mountpoint,
> > so it makes no sense to provide one w/out.
> > 
> > This fact also holds for subclasses of EFI, taking into consideration
> > whether
> > or not isEFI is True.
> > 
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  platform.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/platform.py b/platform.py
> > index 51e2e3f..3ff05ab 100644
> > --- a/platform.py
> > +++ b/platform.py
> > @@ -253,7 +253,8 @@ class EFI(Platform):
> >          for part in self.anaconda.id.storage.partitions:
> >             if part.disk and part.disk.name == drive \
> >                 and part.format.type == "efi" \
> > -               and self.validBootPartSize(part.size):
> > +               and self.validBootPartSize(part.size) \
> > +               and part.format.mountpoint:
> >                  return part
> >          return None
> >  
> > --
> > 1.9.3
> 
> I gave this a try and with 'replace linux' autopart option and with 2
> existing ESP's it created a 3rd one, so this is preventing it from
> picking an existing ESP. I think it does actually need to fallback to
> picking the first if none have a mountpoint.
> 
> --
> Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA
> (PST8PDT)
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Thanks, posted another try w/ title
Make sure EFI.bootDevice() satisfies EFI.checkBootRequest() (#1145812).

- mulhern


More information about the anaconda-patches mailing list