[PATCH] Fix up quoting around passing args to anaconda in the gui test.

Martin Kolman mkolman at redhat.com
Fri May 30 07:50:17 UTC 2014



----- Original Message -----
> From: "Chris Lumens" <clumens at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Thursday, May 29, 2014 8:07:23 PM
> Subject: Re: [PATCH] Fix up quoting around passing args to anaconda in the	gui test.
> 
> > I'm not sure the part with the quotes around $1 does what you want
> > it to do.
> 
> I can probably just drop the quotes around $1.  Do I really expect
> people to make live CD images with spaces in them?
Well, I guess you never know. :) On the other hand, I guess we can wait
for someone to raise a bug and make a case why making live CDs with spaces 
in image filename is a good idea. :)
> 
> > If the problem you're having here is just with $2 needing
> > to quoted or omitted, I think the cleaner (if maybe not easier to
> > read) way would be to use set and $@. Something like
> > 
> > liveimage="$1"
> > otherthing="$2"
> > set -- -s -v --nologcapture --tc=resultsdir:$(mktemp -d
> > --tmpdir=/var/tmp autogui-results-XXXXXX)
> > --tc=liveImage:"${liveimage}"
> > if [ ! -z "${otherthing}" ]; then
> >     set -- "$@" "${otherthing}"
> > fi
> > nosetests "$@" outside
> 
> I don't have the first clue what any of this does.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list