[blivet:master 23/26] Distribute devicefactory.get_raid_level within devices classes.

David Lehman dlehman at redhat.com
Thu May 29 22:34:32 UTC 2014


On 05/29/2014 01:47 PM, mulhern wrote:
> Change the name to raidLevel, make it a property, and change the
> return type to a RAIDLevel object.

The way this was defined in devicefactory is fairly specific to 
anaconda's GUI.  I have doubts as to whether it is general enough to 
live in the device classes. In fact, I think it would make more sense in 
anaconda's custom_storage_helpers than in the device classes themselves. 
in the device classes it is somewhat confusing how some devices get 
their raidLevel from another device in the stack, while others do not. 
In a GUI helper function such an inconsistency is easily understood.

David


More information about the anaconda-patches mailing list