[PATCH 5/5] (One more for the set:) Don't hide a serious issue

Vratislav Podzimek vpodzime at redhat.com
Wed May 28 10:07:12 UTC 2014


Instead of hiding a serious issue, we should let the installer crash and ask
user to report it as a bug.

Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
---
 pyanaconda/ui/tui/spokes/storage.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py
index 40b7c35..c1699fd 100644
--- a/pyanaconda/ui/tui/spokes/storage.py
+++ b/pyanaconda/ui/tui/spokes/storage.py
@@ -550,10 +550,4 @@ class PartitionSchemeSpoke(NormalTUISpoke):
         """ Apply our selections. """
 
         schemelist = self.partschemes.values()
-        try:
-            self.data.autopart.type = schemelist[self._selection]
-        except IndexError:
-            # we shouldn't ever see this, but just in case, don't crash.
-            # when autopart.type is detected as None in AutoPartSpoke.apply(),
-            # it'll automatically just be set to LVM
-            pass
+        self.data.autopart.type = schemelist[self._selection]
-- 
1.9.3



More information about the anaconda-patches mailing list