[blivet 0/2] Validate things for LVM, v3

Anne Mulhern amulhern at redhat.com
Wed May 21 12:03:27 UTC 2014





----- Original Message -----
> From: "David Shea" <dshea at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, May 20, 2014 10:47:04 AM
> Subject: [blivet 0/2] Validate things for LVM, v3
> 
> Changes the isNameValid property from the previous version to a classmethod,
> and uses this method during __init__ and in the new name setter.
> 
> No changes to the anaconda patch, so I'm not resending it.
> 
> David Shea (2):
>   Use a setter for Device.name as foretold by the prophecy of TODO
>   Validate device names
> 
>  blivet/__init__.py      |   8 +++-
>  blivet/devicefactory.py |  14 +++---
>  blivet/devices.py       | 120
>  +++++++++++++++++++++++++++++++++++++++++-------
>  tests/devices_test.py   |  40 ++++++++++++++++
>  4 files changed, 156 insertions(+), 26 deletions(-)
> 
> --
> 1.9.0
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

These look fine to me. I see an MDRaidArrayDevice.isNameValid()
in the pretty near future, I think.

- mulhern


More information about the anaconda-patches mailing list