lorax: [PATCH] Add --add-template{,-var}

Colin Walters walters at verbum.org
Mon May 12 17:23:34 UTC 2014


> Your email client seems to be mangling the patches,

Yeah, I think Geary is word wrapping =/

>  or maybe you're
> using tabs? For patches of this size I need to be able to git am them,
> or pick them from a remote repo.

Ok, if you guys don't mind the remote repo flow, can we do that?  It's 
easier for me than switching/patching mail clients for me.

> I also like to see new options added to the end, 

Done.

> not inserted in the
> middle, and Vratislav's comments about setting them to None and 
> checking
> them is correct.

Done.

> This validation should be done earlier so that you don't have to wait 
> to
> find out the stuff you passed is wrong. At least in Lorax.run() if not
> also when the args are parsed in the lorax script.

Ok, done.  I've pushed to here:

https://github.com/cgwalters/lorax/commit/a40fab8fc76193fcc261dd1e0e342e2d8e0c862c






More information about the anaconda-patches mailing list