[anaconda][master][PATCH 0/2] Improving the anaconda CLI help - foundations

Martin Kolman mkolman at redhat.com
Mon May 12 11:39:21 UTC 2014


On Mon, 2014-05-12 at 09:09 +0200, Vratislav Podzimek wrote:
> On Wed, 2014-05-07 at 17:09 +0200, Martin Kolman wrote:
> > As I've started on improving our CLI help, I've noticed that if Anaconda is currently called
> > with either one of the -h or --help switches, it takes up to a couple of seconds to react
> > and also spams the stdout with confusing messages such as:
> > 
> > Starting installer, one moment...
> > dm.c: 1693: not running as root returning empty list
> > 
> > The first patch gets rid of both the delay and the spam by starting option-parsing
> > at once when "--help" or "-h" is detected in the CLI options.
> > 
> > The second one is a nice-to-have/optional patch, which removes the need to query Anaconda
> > version (and thus to import iutil) when only the help text is being returned.
> > This makes it possible to get the Anaconda CLI help even if the given Anaconda does not have
> > a compiled iutil (fresh clone from Git, etc.).
> I think a better solution for this would be moving the
> getAnacondaVersion() function out of iutil. We could have a
> version.py.in module with a macro replaced by the 'configure' script.
> 
Yeah, I think that the smaller isys gets, the better. So I'll drop patch
2/2 for now and will do a separate get-version-out-of-isys/iutil patch
as suggested.



More information about the anaconda-patches mailing list