[PATCH 0/3] Adding pylint to lorax

Brian C. Lane bcl at redhat.com
Fri May 9 00:50:31 UTC 2014


This set adds pylint to lorax and cleans up all the warnings that were found.
Happily enough there were no errors.

The false positive on version is because the version isn't added until build
time, so it cannot be imported while in a clean checkout.

Brian C. Lane (3):
  Add pylint testing
  Cleanup pylorax pylint warnings
  Cleanup other misc pylint warnings

 Makefile                            |   4 ++
 setup.py                            |   1 -
 src/bin/image-minimizer             |  22 +++---
 src/pylorax/__init__.py             |  30 ++++----
 src/pylorax/base.py                 |   2 +-
 src/pylorax/executils.py            |  33 ++++-----
 src/pylorax/imgutils.py             |  65 ++++++++++-------
 src/pylorax/ltmpl.py                |  37 +++++-----
 src/pylorax/output.py               |  32 ++++-----
 src/pylorax/sysutils.py             |   5 +-
 src/pylorax/treebuilder.py          |  31 ++++----
 src/pylorax/yumhelper.py            |   2 +-
 src/sbin/livemedia-creator          |  16 +++--
 src/sbin/lorax                      |   8 ++-
 src/sbin/mkefiboot                  |   5 +-
 tests/lib/testlib.sh                |  37 ++++++++++
 tests/pylint/pylint-false-positives |   3 +
 tests/pylint/pylint-one.sh          |  32 +++++++++
 tests/pylint/runpylint.sh           | 140 ++++++++++++++++++++++++++++++++++++
 tests/testenv.sh                    |  19 +++++
 utils/filediff.py                   |   8 +--
 utils/test-parse-template           |   4 +-
 22 files changed, 401 insertions(+), 135 deletions(-)
 create mode 100644 tests/lib/testlib.sh
 create mode 100644 tests/pylint/pylint-false-positives
 create mode 100755 tests/pylint/pylint-one.sh
 create mode 100755 tests/pylint/runpylint.sh
 create mode 100644 tests/testenv.sh

-- 
1.9.0



More information about the anaconda-patches mailing list