[anaconda][master][PATCH 0/2] Improving the anaconda CLI help - foundations

Anne Mulhern amulhern at redhat.com
Wed May 7 16:02:42 UTC 2014





----- Original Message -----
> From: "Martin Kolman" <mkolman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Wednesday, May 7, 2014 11:09:18 AM
> Subject: [anaconda][master][PATCH 0/2] Improving the anaconda CLI help -	foundations
> 
> As I've started on improving our CLI help, I've noticed that if Anaconda is
> currently called
> with either one of the -h or --help switches, it takes up to a couple of
> seconds to react
> and also spams the stdout with confusing messages such as:
> 
> Starting installer, one moment...
> dm.c: 1693: not running as root returning empty list
> 
> The first patch gets rid of both the delay and the spam by starting
> option-parsing
> at once when "--help" or "-h" is detected in the CLI options.
> 
> The second one is a nice-to-have/optional patch, which removes the need to
> query Anaconda
> version (and thus to import iutil) when only the help text is being returned.
> This makes it possible to get the Anaconda CLI help even if the given
> Anaconda does not have
> a compiled iutil (fresh clone from Git, etc.).
> 
> Martin Kolman (2):
>   Return CLI help text at once
>   Don't check anaconda version if just returning the CLI help text
> 
>  anaconda | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> --
> 1.9.0
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Ack on your first patch, but the second feels like it might be going too far.

- mulhern


More information about the anaconda-patches mailing list