[anaconda:master 4/4] Remove keyword args 'ignoreErrors' from umountFilesystems() call.

Brian C. Lane bcl at redhat.com
Mon May 5 23:42:49 UTC 2014


On Mon, May 05, 2014 at 10:47:28AM -0400, Anne Mulhern wrote:
> 
> Just removing the parameter doesn't change anything, because it was being
> ignored anyway.

Oh, ha! No change in behavior then :)

> 
> But, at a point in the past, for the mountFilesystems() method,
> a similar flag was disregarded in favor of a filewide errorHandler object.
> If running as part of the installer, the ErrorHandler object is overwritten
> by the one in pyanaconda.errors.
> The history is actually more complicated than that, but that was the
> upshot. The error handler decides how to treat the exception based on the
> exception object, not on the context on which it was called, of course.
> 
> I'm assuming here, that the umountFilesystems() method ought to work similarly.
> Right now, the errorHandler object is not used in the method, so any errors
> raised will be propagated. But that can be changed, as you suggest.

Thanks for the explanation.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list