[blivet] Move some useful functions out of examples/common.py
Anne Mulhern
amulhern at redhat.com
Mon May 5 21:54:13 UTC 2014
----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Monday, May 5, 2014 1:56:59 PM
> Subject: [blivet] Move some useful functions out of examples/common.py
>
> David Lehman (4):
> Make examples.common.tear_down_disk_images a DeviceTree method.
> Move set_up_logging and create_sparse_file into blivet.util for reuse.
> Change devices.SparseFileDevice._create to use
> util.create_sparse_file.
> Adapt examples to examples/common.py function dispersement.
>
> blivet/devices.py | 5 +----
> blivet/devicetree.py | 12 ++++++++++++
> blivet/util.py | 29 +++++++++++++++++++++++++++++
> examples/common.py | 37 -------------------------------------
> examples/factory.py | 19 +++++--------------
> examples/list_devices.py | 12 ++----------
> examples/lvm.py | 17 ++++-------------
> examples/partitioning.py | 19 +++++--------------
> 8 files changed, 58 insertions(+), 92 deletions(-)
>
> --
> 1.9.0
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>
These changes look fine to me, but I'ld like to see the
corresponding anaconda patches as well.
tear_down_disk_images() has changed its signature, and I
think that the calls to create_sparse_file() should probably
become calls to create_temp_file() in anaconda/tests.
- mulhern
More information about the anaconda-patches
mailing list