[blivet:master 00/16] A mixed bag of pylint patches

mulhern amulhern at redhat.com
Thu May 1 13:08:37 UTC 2014


The interesting ones are:

Pass size value...I may be wrong here.
Remove unused parameter 'ignoreErrors'...and following patches will need
corresponding changes to anaconda in most cases. I'll be sending a patch set
for that as well.

mulhern (16):
  Remove obsolete documentation for parameter 'label'.
  Put the pyblock warning in pylint-false-positives
  Omit pylint warning about disabled warnings or errors from pylint log.
  Do not disable unused argument warning.
  Sort the pylint-false-positives file
  Pass size value to superconstructor for LVMVolumeGroupDevice.
  Set dummy functions as values rather than via function definition
    syntax.
  Disable unused argument warning for 'major' and 'minor'
  Remove parameter 'raiseErrors' from mountFilesystems() methods.
  Remove unused parameter 'ignoreErrors' from umountFilesystems()
  Change ActionCreateFormat constructor keyword argument to 'fmt'
  Change keyword parameters in devicetree.findActions
  Change format keyword argument to fmt in scheduleCreateFormat
  Change all 'format' keyword args to 'fmt' in Device constructors
  Change Size so that it takes a single value parameter.
  Make Size.__new__ match Decimal.__new__

 blivet/__init__.py                   | 100 +++++++---------
 blivet/deviceaction.py               |  10 +-
 blivet/devicefactory.py              |  24 ++--
 blivet/devicelibs/crypto.py          |  29 ++---
 blivet/devicelibs/lvm.py             |  20 ++--
 blivet/devicelibs/mdraid.py          |  10 +-
 blivet/devicelibs/swap.py            |   8 +-
 blivet/devices.py                    | 176 ++++++++++++++--------------
 blivet/devicetree.py                 |  27 +++--
 blivet/errors.py                     |   3 -
 blivet/formats/__init__.py           |   4 +-
 blivet/formats/biosboot.py           |   4 +-
 blivet/formats/disklabel.py          |   6 +-
 blivet/formats/fs.py                 |  49 ++++----
 blivet/formats/prepboot.py           |   4 +-
 blivet/formats/swap.py               |   2 +-
 blivet/partitioning.py               |  36 +++---
 blivet/platform.py                   |  20 ++--
 blivet/size.py                       |  59 +++++-----
 blivet/udev.py                       |  10 +-
 blivet/util.py                       |   4 +-
 tests/action_test.py                 | 214 +++++++++++++++++------------------
 tests/devicefactory_test.py          |   4 +-
 tests/devicelibs_test/lvm_test.py    |  38 +++----
 tests/devicelibs_test/mdraid_test.py |  36 +++---
 tests/devices_test.py                | 132 ++++++++++-----------
 tests/pylint/pylint-false-positives  |   7 +-
 tests/pylint/runpylint.sh            |   4 +-
 tests/sanity_check_test.py           |   4 +-
 tests/size_test.py                   |  65 +++++------
 tests/storagetestcase.py             |   2 +-
 31 files changed, 540 insertions(+), 571 deletions(-)

-- 
1.8.3.1



More information about the anaconda-patches mailing list