[blivet] refactor lvm info gathering

Anne Mulhern amulhern at redhat.com
Mon Mar 31 15:17:46 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, March 31, 2014 3:52:16 AM
> Subject: Re: [blivet] refactor lvm info gathering
> 
> On Fri, 2014-03-28 at 15:32 -0500, David Lehman wrote:
> > This slightly improves how we gather information from lvm about
> > existing devices. It then adds caching to consolidate calls to lvm
> > utilities on systems with many PVs and/or VGs.
> > 
> > This version does not enable caching for anaconda, but I think I
> > should remove that piece. Does anyone object? What it means is that
> > we'll only run pvs and lvs once per call to DeviceTree.populate,
> > regardless of the number of PVs or VGs present. I think we call
> > populate after any operation that could add a new PV in anaconda, so
> > it should be safe.
> I think you can remove that piece, it could only reveal a missing
> populate call if there is some.
> 
> Other than those neatpick comments, these all look good to me.
> 
> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

No comments on (2) and (4) in this set.

- mulhern


More information about the anaconda-patches mailing list