[master/rhel7(.1)] Check xconfig before setting the installed displaymode (#1081768)

Vratislav Podzimek vpodzime at redhat.com
Mon Mar 31 07:58:37 UTC 2014


On Sun, 2014-03-30 at 10:45 -0400, David Shea wrote:
> Resolves: rhbz#1081768
> ---
>  anaconda | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/anaconda b/anaconda
> index 42af682..b289554 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -1030,8 +1030,10 @@ if __name__ == "__main__":
>      setupDisplay(anaconda, opts, addon_paths)
>  
>      # if we're in text mode, the resulting system should be too
> +    # ...unless the kickstart specified otherwise
>      if anaconda.displayMode != 'g':
> -        anaconda.ksdata.skipx.skipx = True
> +        if not anaconda.ksdata.xconfig.seen:
> +            anaconda.ksdata.skipx.skipx = True
Shouldn't we check xconfig.startX? I'm not sure that e.g. specifying
default desktop should result with system booting to graphical mode. For
example it is a valid setting for XVnc-only system as well.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list