[blivet:master 00/14] Miscellaneous pylint inspired patches

mulhern amulhern at redhat.com
Fri Mar 28 22:50:25 UTC 2014


These are all fairly simple and were all inspired by some pylint error.

mulhern (14):
  Change to a semantically equivalent version of FileDevice.path
  Change param default [] to None and convert in method
  Indent with spaces, not tabs
  Move lines beneath __main__ into a main method
  Omit compile flag
  Keep first parameter "self"
  Remove appendiceal assignment
  Put docstring in class
  Remove unused variable but retain call for its side-effects
  Get rid of writeRandomUUID.
  Suppress unused variable warning
  Do not import logging twice.
  Raise exceptions using the new syntax
  Rearrange _startEdd to be a little more obvious.

 blivet/__init__.py                  |  2 +-
 blivet/arch.py                      |  3 ---
 blivet/devicelibs/lvm.py            |  5 ++++-
 blivet/devicelibs/mdraid.py         |  7 +++++--
 blivet/devices.py                   | 12 +++---------
 blivet/fcoe.py                      |  8 ++------
 blivet/formats/fs.py                | 19 -------------------
 blivet/tsort.py                     |  7 +++----
 scripts/makeupdates                 | 10 ++++++----
 tests/action_test.py                |  7 ++++---
 tests/devicelibs_test/baseclass.py  |  8 ++++----
 tests/devicelibs_test/btrfs_test.py |  4 ++--
 tests/storagetestcase.py            | 14 ++++++--------
 13 files changed, 40 insertions(+), 66 deletions(-)

-- 
1.8.3.1



More information about the anaconda-patches mailing list