[blivet:master 4/7] Don't get return values from communicate() if they are ignored

mulhern amulhern at redhat.com
Thu Mar 27 14:39:00 UTC 2014


Signed-off-by: mulhern <amulhern at redhat.com>
---
 tests/devicelibs_test/baseclass.py  | 6 +++---
 tests/devicelibs_test/btrfs_test.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/devicelibs_test/baseclass.py b/tests/devicelibs_test/baseclass.py
index a203af5..984ed74 100644
--- a/tests/devicelibs_test/baseclass.py
+++ b/tests/devicelibs_test/baseclass.py
@@ -8,7 +8,7 @@ def makeLoopDev(device_name, file_name):
                              "bs=1024", "count=102400"],
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     while True:
-        (out, err) = proc.communicate()
+        proc.communicate()
         if proc.returncode is not None:
             rc = proc.returncode
             break
@@ -18,7 +18,7 @@ def makeLoopDev(device_name, file_name):
     proc = subprocess.Popen(["losetup", device_name, file_name],
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     while True:
-        (out, err) = proc.communicate()
+        proc.communicate()
         if proc.returncode is not None:
             rc = proc.returncode
             break
@@ -29,7 +29,7 @@ def removeLoopDev(device_name, file_name):
     proc = subprocess.Popen(["losetup", "-d", device_name],
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     while True:
-        (out, err) = proc.communicate()
+        proc.communicate()
         if proc.returncode is not None:
             rc = proc.returncode
             break
diff --git a/tests/devicelibs_test/btrfs_test.py b/tests/devicelibs_test/btrfs_test.py
index fdfb59b..8c575d1 100755
--- a/tests/devicelibs_test/btrfs_test.py
+++ b/tests/devicelibs_test/btrfs_test.py
@@ -41,7 +41,7 @@ class BTRFSMountDevice(baseclass.DevicelibsTestCase):
         """
         proc = subprocess.Popen(["umount", self.device])
         while True:
-            (out, err) = proc.communicate()
+            proc.communicate()
             if proc.returncode is not None:
                 rc = proc.returncode
                 break
-- 
1.8.3.1



More information about the anaconda-patches mailing list