[PATCH] safe_dbus: Don't export DBus connection addresses as variables

Vratislav Podzimek vpodzime at redhat.com
Thu Mar 27 10:15:59 UTC 2014


On Wed, 2014-03-26 at 20:30 -0400, Colin Walters wrote:
> On Wed, 2014-03-26 at 09:28 +0100, Vratislav Podzimek wrote:
> 
> > Could you please use git-send-email for sending patches? It simplifies
> > review process.
> 
> That will be challenging for me...I have multifactor authentication
> to my mail host, and I really don't want to teach git how to speak
> SMTP for my setup.
> 
> Does anyone know of any way to teach Evolution (or Geary) how to
> receive input via git-send-email?  It's hard to Google for.
> 
> > The patch looks good to me, altough now that I look at those functions
> > in the safe_dbus module I think we should trim the dbus_ prefix from
> > them as their names are quite long. And you can drop "_sync" from the
> > newly added function.
> 
> I have a request - for small things like this, I'd really
> appreciate it if someone could just make the requisite fixes and
> commit.  I have a huge amount of work to do, and every round trip
> for these patches greatly increases the latency.
> 
> I'm happy to have patches entirely bounced if they don't conform
> to style guidelines and such.  But if you just want to rename something,
> can you just do it?
Fixed syntax error and unused import and pushed to master. Proposed an
additional patch renaming all the functions.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list