[blivet:master 00/10] Small pylint inspired patches

mulhern amulhern at redhat.com
Tue Mar 25 15:48:59 UTC 2014


These are a bunch of small and pretty obvious changes inspired by pylint
warnings.

* Catch correct error and disable warning is the only actual bug fix. You need
to fail to parse /proc/mounts correctly to make it manifest, though.

mulhern (10):
  Catch correct error and disable warning.
  Give abstract method the same signature as its overriding methods.
  Spell parameter self correctly
  Put a field and a method in the base class
  Get rid of unnecessary pass statements
  Don't comment out function headers but leave their bodies uncommented
  Delete method-local pruneFile function.
  Remove unused assignment to boot.
  Remove some unused exception names.
  Replace with a semantically equivalent chunk.

 blivet/__init__.py                |  6 +-----
 blivet/devicelibs/raid.py         |  2 +-
 blivet/devices.py                 |  7 ++-----
 blivet/devicetree.py              |  8 +++-----
 blivet/formats/fslabel.py         | 19 +++++++++++++++----
 blivet/iscsi.py                   |  1 -
 blivet/util.py                    |  4 ++--
 scripts/makeupdates               |  9 ---------
 tests/devicelibs_test/lvm_test.py |  9 ---------
 9 files changed, 24 insertions(+), 41 deletions(-)

-- 
1.8.3.1



More information about the anaconda-patches mailing list