[master][PATCH] Don't do yum lock logging when using updates.img

Martin Kolman mkolman at redhat.com
Tue Mar 25 09:26:11 UTC 2014


Vratislav Podzimek píše v Út 25. 03. 2014 v 09:26 +0100:
> The commit d42a7caa turned on debug logging when using updates.img. However,
> that also turns on yum lock logging which is kind of a flood for the
> packaging.log and which prolongs anaconda-tb file generation a lot. We only want
> to do yum lock logging when inst.debug is used.
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> ---
>  anaconda | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/anaconda b/anaconda
> index 7e84cf5..26f0d3a 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -375,19 +375,23 @@ def setupEnvironment():
>          del os.environ["LD_PRELOAD"]
>  
>  def setupLoggingFromOpts(options):
> +    want_yum_lock_logs = False
>      if options.debug or options.updateSrc:
>          # debugging means debug logging
>          options.loglevel = "debug"
> +        want_yum_lock_logs = options.debug
>  
>      if options.loglevel and anaconda_log.logLevelMap.has_key(options.loglevel):
>          level = anaconda_log.logLevelMap[opts.loglevel]
>          anaconda_log.logger.tty_loglevel = level
>          anaconda_log.setHandlersLevel(log, level)
> -        packaging_log = logging.getLogger("packaging")
> -        anaconda_log.setHandlersLevel(packaging_log, level)
>          storage_log = logging.getLogger("storage")
>          anaconda_log.setHandlersLevel(storage_log, level)
>  
> +        if options.loglevel != "debug" or want_yum_lock_logs:
> +            packaging_log = logging.getLogger("packaging")
> +            anaconda_log.setHandlersLevel(packaging_log, level)
> +
>      if options.syslog:
>          anaconda_log.logger.updateRemote(options.syslog)
>  
Good idea! Those YUM lock messages are really making the packaging log
unusable without extensive filtering. Patch looks good, so ACK!



More information about the anaconda-patches mailing list