[blivet:rhel7/master 4/4] Skip lvm test case with an informative message

Anne Mulhern amulhern at redhat.com
Mon Mar 24 22:24:08 UTC 2014


I'm pulling this patch. I had misremembered the details of the lvm version requirements.

- mulhern

----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Monday, March 24, 2014 2:43:02 PM
> Subject: Re: [blivet:rhel7/master 4/4] Skip lvm test case with an	informative message
> 
> On Fri, 2014-03-21 at 15:29 -0400, mulhern wrote:
> > Just now, our test case needs a fairly recent version of lvm2 to run, which
> > isn't available on my desktop.
> 
> This should either check the lvm2 version or get dropped.
> 
> > 
> > This isn't a problem for blivet itself, just the for the unit test.
> > 
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  tests/devicelibs_test/lvm_test.py | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/devicelibs_test/lvm_test.py
> > b/tests/devicelibs_test/lvm_test.py
> > index 03700ae..b7d6b6d 100755
> > --- a/tests/devicelibs_test/lvm_test.py
> > +++ b/tests/devicelibs_test/lvm_test.py
> > @@ -67,6 +67,7 @@ class LVMAsRootTestCase(baseclass.DevicelibsTestCase):
> >          super(LVMAsRootTestCase, self).tearDown()
> >  
> >      @unittest.skipUnless(os.geteuid() == 0, "requires root privileges")
> > +    @unittest.skipUnless(False, "you are probably running a version of
> > lvcreate which does not accept the -y flag")
> >      def testLVM(self):
> >          _LOOP_DEV0 = self._loopMap[self._LOOP_DEVICES[0]]
> >          _LOOP_DEV1 = self._loopMap[self._LOOP_DEVICES[1]]
> 
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list