[blivet:master 0/6] A bunch of pylint inspired patches

Anne Mulhern amulhern at redhat.com
Fri Mar 21 20:34:05 UTC 2014





----- Original Message -----
> From: "mulhern" <amulhern at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Cc: "mulhern" <amulhern at redhat.com>
> Sent: Friday, March 21, 2014 4:17:09 PM
> Subject: [blivet:master 0/6] A bunch of pylint inspired patches
> 
> These are a bunch of, I believe, extremely non-controversial pylint inpsired
> changes courtesy of David Shea.
> 
> The only question, I think, is whether some of these should also be queued up
> for RHEL7.1. If you have an opinion on that, please speak up.
> 
> The sooner I can push these, the less rebasing I'll have to do!
> 
> David Shea (6):
>   Fix logging function string format warnings.
>   Fixed some questionable indentation
>   Specify regular expressions containing backslashes as raw strings
>   Removed a redundant definition of NoDisksError
>   Removed an unnecessary semicolon
>   Update to the new raise syntax
> 
>  blivet/__init__.py          | 136 ++++++++++-----------
>  blivet/arch.py              |   6 +-
>  blivet/dasd.py              | 216 +++++++++++++++++++++++++++++++++
>  blivet/deviceaction.py      |   2 +-
>  blivet/devicefactory.py     | 110 ++++++++---------
>  blivet/devicelibs/dasd.py   |   3 +-
>  blivet/devicelibs/edd.py    |  28 ++---
>  blivet/devicelibs/lvm.py    |  10 +-
>  blivet/devicelibs/mdraid.py |   6 +-
>  blivet/devicelibs/swap.py   |   6 +-
>  blivet/devices.py           |  76 ++++++------
>  blivet/devicetree.py        | 282
>  ++++++++++++++++++++++----------------------
>  blivet/errors.py            |   3 -
>  blivet/fcoe.py              |  14 +--
>  blivet/formats/__init__.py  |  18 +--
>  blivet/formats/disklabel.py |  10 +-
>  blivet/formats/fs.py        |  36 +++---
>  blivet/formats/luks.py      |   6 +-
>  blivet/formats/prepboot.py  |  12 +-
>  blivet/formats/swap.py      |   2 +-
>  blivet/iscsi.py             |  51 ++++----
>  blivet/partitioning.py      | 266 +++++++++++++++++++++--------------------
>  blivet/platform.py          |  16 +--
>  blivet/pyudev.py            |   2 +-
>  blivet/udev.py              |  22 ++--
>  blivet/util.py              |  30 ++---
>  blivet/zfcp.py              |  89 +++++++-------
>  27 files changed, 832 insertions(+), 626 deletions(-)
>  create mode 100644 blivet/dasd.py
> 
> --
> 1.8.3.1
> 
> 

The first patch accidentally added blivet/dasd.py back in, but that's fixed in the working copy.

- mulhern


More information about the anaconda-patches mailing list