[PATCH 2/9] Add a ContainerDevice class to consolidate member management code.

Anne Mulhern amulhern at redhat.com
Fri Mar 21 15:16:55 UTC 2014





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Friday, March 21, 2014 11:04:35 AM
> Subject: Re: [PATCH 2/9] Add a ContainerDevice class to consolidate member	management code.
> 
> On Fri, 2014-03-21 at 08:36 +0100, Vratislav Podzimek wrote:
> > >      def __repr__(self):
> > > -        s = DMDevice.__repr__(self)
> > > +        s = ContainerDevice.__repr__(self)
> > This should probably use super().
> 
> Fixed.
> 
> > 
> 
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

My general comment is that more information about the way the new ContainerDevice class
is supposed to be used in its class documentation would be good.

Also, it looks like an abstract class that should not be instantiated so it
might be helpful to enforce some of its properties with abc.

- mulhern


More information about the anaconda-patches mailing list