[blivet:rhel7/master] An obvious fix to blivet.Blivet.savePassphrase.

Anne Mulhern amulhern at redhat.com
Fri Mar 21 13:00:37 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Friday, March 21, 2014 8:47:02 AM
> Subject: Re: [blivet:rhel7/master] An obvious fix to	blivet.Blivet.savePassphrase.
> 
> On Fri, 2014-03-21 at 08:45 -0400, mulhern wrote:
> > Occasioned by an "Instance of DeviceTree has no '_DeviceTree__luksDev'
> > member"
> > pylint error.
> > 
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  blivet/__init__.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/blivet/__init__.py b/blivet/__init__.py
> > index f361844..2bc1243 100644
> > --- a/blivet/__init__.py
> > +++ b/blivet/__init__.py
> > @@ -1469,8 +1469,8 @@ class Blivet(object):
> >          """ Save a device's LUKS passphrase in case of reset. """
> >          passphrase = device.format._LUKS__passphrase
> >          self.__luksDevs[device.format.uuid] = passphrase
> > -        self.devicetree._DeviceTree__luksDevs[device.format.uuid] =
> > passphrase
> > -        self.devicetree._DeviceTree__passphrases.append(passphrase)
> > +        self.devicetree.__luksDevs[device.format.uuid] = passphrase
> > +        self.devicetree.__passphrases.append(passphrase)
> I'd rather see those '__' go.
> 
> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

I'm withdrawing this patch, actually. I just realized that what I'm looking
at is probably a Python mangled name that actually works.

Which explains why it hasn't crashed on somebody by now.

- mulhern



More information about the anaconda-patches mailing list