[PATCH 3/9] Adapt callers to new method names for add/remove member device.
Vratislav Podzimek
vpodzime at redhat.com
Fri Mar 21 07:38:19 UTC 2014
On Thu, 2014-03-20 at 12:14 -0500, David Lehman wrote:
> ---
> blivet/devicefactory.py | 26 +++++++++++++-------------
> blivet/devicetree.py | 10 +++++-----
> 2 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py
> index d1e4779..9d752bf 100644
> --- a/blivet/devicefactory.py
> +++ b/blivet/devicefactory.py
> @@ -482,11 +482,11 @@ class DeviceFactory(object):
> log.debug("old member set: %s" % [d.name for d in self.container.parents])
> for member in self.container.parents[:]:
> if member not in members:
> - self.container.removeMember(member)
> + self.container._removeMember(member)
Why are those methods all private even if we want to call them directly?
As I see it no public wrappers are needed and they can simply be made
public.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list