[blivet:master 0/4] Make blivet pylintable

Brian C. Lane bcl at redhat.com
Thu Mar 20 01:26:56 UTC 2014


On Wed, Mar 19, 2014 at 12:54:51PM -0400, mulhern wrote:
> These patches add ability to run pylint on blivet similarly to how it is
> run on anaconda.
> 
> There is an additional script that can be run to show only pylint errors that
> correspond to lines added since commit <SHA1>. It requires that diff-cover
> be installed and diff-quality be in your path.
> 
> I would like this patch set reviewed and pushed
> before I begin sending patches addressing
> existing pylint errors for review. I hope the included script will
> encourage people to run pylint on their new code and fix errors in that 
> code. I believe that the review process for patches that fix existing 
> errors will be lengthy and that it is better to be able to use pylint now
> on new code than to wait until all existing pylint errors are dealt with.
> 
> mulhern (4):
>   Do an initial setup for running pylint tests in blivet.
>   Change output format so that it is suitable for diff-cover.
>   Add a script to relate pylint errors to lines changed.
>   Remove non-doing check target
> 
>  Makefile                            |   4 -
>  scripts/pylintcodediff              | 143 ++++++++++++++++++++++++++++++++++++
>  tests/pylint/intl.py                |  63 ++++++++++++++++
>  tests/pylint/pylint-false-positives |   0
>  tests/pylint/pylint-one.sh          |  33 +++++++++
>  tests/pylint/runpylint.sh           | 127 ++++++++++++++++++++++++++++++++
>  tests/testenv.sh                    |  13 ++++
>  7 files changed, 379 insertions(+), 4 deletions(-)
>  create mode 100755 scripts/pylintcodediff
>  create mode 100644 tests/pylint/intl.py
>  create mode 100644 tests/pylint/pylint-false-positives
>  create mode 100755 tests/pylint/pylint-one.sh
>  create mode 100755 tests/pylint/runpylint.sh
>  create mode 100644 tests/testenv.sh

These look good to me (with 5/5)

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list