[PATCH] The custom spoke requires mountPointStore and mountPointCompletion, too.
Vratislav Podzimek
vpodzime at redhat.com
Wed Mar 19 14:27:34 UTC 2014
On Wed, 2014-03-19 at 10:14 -0400, David Shea wrote:
> On 03/19/2014 03:41 AM, Vratislav Podzimek wrote:
> > On Tue, 2014-03-18 at 14:40 -0400, Chris Lumens wrote:
> >> ---
> >> pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >>
> >> diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade
> >> index e26129a..81938e9 100644
> >> --- a/pyanaconda/ui/gui/spokes/custom.glade
> >> +++ b/pyanaconda/ui/gui/spokes/custom.glade
> >> @@ -3,6 +3,15 @@
> >> <interface>
> >> <!-- interface-requires gtk+ 3.2 -->
> >> <!-- interface-requires AnacondaWidgets 1.0 -->
> >> + <object class="GtkListStore" id="mountPointStore">
> >> + <columns>
> >> + <!-- column-name path -->
> >> + <column type="gchararray"/>
> >> + </columns>
> >> + </object>
> >> + <object class="GtkEntryCompletion" id="mountPointCompletion">
> >> + <property name="model">mountPointStore</property>
> >> + </object>
> >> <object class="AnacondaSpokeWindow" id="customStorageWindow">
> >> <property name="can_focus">False</property>
> >> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
> > NACK. The custom spoke actually doesn't need those two objects. They
> > were incorrectly listed in the builderObjects list. Sending a new patch.
> >
>
> If that's the case then there's also a problem with this in custom.glade:
>
> <object class="GtkEntry"
> id="mountPointEntry">
> <property
> name="visible">True</property>
> <property
> name="can_focus">True</property>
> <property
> name="hexpand">True</property>
> <property
> name="invisible_char">●</property>
> <property
> name="completion">mountPointCompletion</property>
> <signal name="changed"
> handler="on_value_changed" swapped="no"/>
> </object>
Ahh, okay, you are right, guys, I've overlooked this. The first
(clumens') patch is the right one, than. Apologies
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list