[master] Another set of tweaks for the Custom spoke
Brian C. Lane
bcl at redhat.com
Sat Mar 15 00:00:15 UTC 2014
On Fri, Mar 14, 2014 at 04:50:58PM +0100, Martin Kolman wrote:
> On Fri, 2014-03-14 at 12:34 +0100, Vratislav Podzimek wrote:
> > These patches make the Custom spoke refresh a bit faster and make the code
> > better readable and maintainable. Well, at least for me.
> >
> > Vratislav Podzimek (5):
> > Use GtkActionList when populating filesystem store
> > Hide and unhide the same set of disks in the Custom spoke
> > Get new devices only once in the _do_refresh method
> > Short-circuit testing if root has any devices
> > Move accordion population into a separate function
> >
> > pyanaconda/ui/gui/spokes/custom.py | 83 +++++++++++++++++++++-----------------
> > 1 file changed, 47 insertions(+), 36 deletions(-)
> >
> All look good to me, ACK!
> BTW, good catch with the new_devices property - one has to love
> properties that are performance intensive. At least it
> (hopefully) does not have side effects. :)
Might be a good reason to turn it into a real method.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
More information about the anaconda-patches
mailing list