[blivet:master] Only log a warning about labeling if something is actually wrong.

Brian C. Lane bcl at redhat.com
Thu Mar 13 17:37:05 UTC 2014


On Wed, Mar 05, 2014 at 11:15:50AM -0500, mulhern wrote:
> If do_labeling is False, then we are not choosing to set a label during
> filesystem creation. Probably we are deferring setting a label until
> after the filesystem has been created.
> If self.label is None then we are accepting the filesystem default label,
> and not setting any label.
> 
> So, we only log a warning if setting a label is what ought to happen but we
> don't want to risk it because it looks like the label format is not accepted
> by this filesystem and that therefore, specifying the label arguments may cause
> failure at filesystem creation.
> 
> Note: Some filesystem creation apps will truncate a label that is just too
> long but others will fail instead. We do not want to distinguish
> among filesystems based on this behavior.
> 
> Signed-off-by: mulhern <amulhern at redhat.com>
> ---
>  blivet/formats/fs.py | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

This looks fine to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list